Add more validation to the OperatorPolicy #207
Merged
+249
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ValidPolicySpec` condition now reports when the subscription or operatorGroup in the policy have unknown fields. It also reports if the InstallPlanApproval value in the subscription is not correct. That condition also reports when the namespace for the subscription does not exist, and the controller now watches that namespace so that if it is created (or deleted), the policy will be reconciled and the status will be updated. Refs: - https://issues.redhat.com/browse/ACM-9993 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JeffeyL
force-pushed
the
9993-operator-validations
branch
from
dbd3f19
to
bd1cebd
Compare
mprahl
approved these changes
Feb 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit c4cfa08
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ValidPolicySpeccondition now reports when the subscription or operatorGroup in the policy have unknown fields. It also reports if the InstallPlanApproval value in the subscription is not correct.That condition also reports when the namespace for the subscription does not exist, and the controller now watches that namespace so that if it is created (or deleted), the policy will be reconciled and the status will be updated.
Refs: